[Webkit-unassigned] [Bug 23305] EditorClient.handleKeyboardEvent() invoked even for non editable node

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23305


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




------- Comment #2 from darin at apple.com  2009-01-14 09:19 PDT -------
I stumbled onto this difference recently while fixing another bug.

I believe this is now different between Mac and the other platforms. The Mac
has an additional test for canEdit in -[WebHTMLView insertText:] that prevents
it from calling through to Editor::insertText, and the equivalent is not
present in other platforms.

I prefer this new behavior on the other platforms to the Mac behavior. I think
it's good to fire the text input event even if the selection is not in an
editable area; editor commands will eventually detect that the selection is not
editable and so the default handler won't do anything.

But I think this something that reasonable people might disagree on; input
methods create some complexity too. I'd like to hear Alexey's take on this.

I don't agree that handleKeyboardEvent should not be invoked, though. That
machinery is responsible for figuring out what key bindings do, and although
it's on the EditorClient it should not be limited to editable areas.

If decide that it's better suppress the text input event, I think we should do
it at the caller of handleTextInputEvent. For example, if we wanted to fix this
on the Windows port, we would add the check to the end of
WebView::handleEditingKeyboardEvent or we could add the check to
Editor::insertText.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.