[Webkit-unassigned] [Bug 23297] Upstream some of platform/graphics/chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23297


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26676|review?                     |review+
               Flag|                            |




------- Comment #2 from eric at webkit.org  2009-01-13 11:44 PDT -------
(From update of attachment 26676)
Looks good except for:
 #ifndef FontPlatformData_h
 32 #define FontPlatformData_h
 33 
 34 #include "config.h"
 35 #include "build/build_config.h"
 36 
 37 #if defined(OS_WIN)
 38 #include "FontPlatformDataChromiumWin.h"
 39 #elif defined(OS_LINUX)
 40 #include "FontPlatformDataLinux.h"
 41 #endif
 42 

We never include config.h in a header.  And I would think we should use WebCore
equivilents to the OS_ defines, like PLATFORM(WIN_OS) and defined(__linux__)
(since we don't seem to have a PLATFORM(LINUX).  Otherwise you're good to land.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.