[Webkit-unassigned] [Bug 23250] NULL string should not be arbitrarily converted to empty string

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23250


tavestbo at trolltech.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26630|review?(tavestbo at trolltech.c|review-
               Flag|om)                         |




------- Comment #2 from tavestbo at trolltech.com  2009-01-13 08:20 PDT -------
(From update of attachment 26630)
> -    QCOMPARE(evalJS("myObject.stringProperty"), QString());
> +    QCOMPARE(evalJS("myObject.stringProperty"), sUndefined);

As discussed on IRC this behavior should apply to QVariants instead.

> +    if (variant.isNull() ) {
> +        if (type == QMetaType::QString)
> +            return jsUndefined();

So that if !variant.isValid() then return jsUndefined();

A default-constructed QVarant is not valid, i.e has the type set to
QMetaType::Invalid


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.