[Webkit-unassigned] [Bug 20412] webkitview.cpp passes negative-value constants as guint

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 13 07:38:25 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=20412


xan.lopez at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26667|                            |review?
               Flag|                            |




------- Comment #3 from xan.lopez at gmail.com  2009-01-13 07:38 PDT -------
Created an attachment (id=26667)
 --> (https://bugs.webkit.org/attachment.cgi?id=26667&action=view)
0001-2009-01-13-Xan-Lopez-xan-gnome.org.patch

commit aeda6d41172041771a67768130db8d38f6ed28f8
Author: Xan Lopez <xan at gnome.org>
Date:   Tue Jan 13 17:36:57 2009 +0200

    2009-01-13  Xan Lopez  <xan at gnome.org>

            Reviewed by NOBODY (OOPS!).

            Reported by Daniel Macks.

            https://bugs.webkit.org/show_bug.cgi?id=20412

            Use positive numbers for the target info IDs, gtk_target_list_add
            casts them to 'guint'. Also just start them from 0, since the
            values are not relevant or magic in any way, they are just used as
            tokens for the user of the API.

            * webkit/webkitwebview.h:

 WebKit/gtk/ChangeLog              |   15 +++++++++++++++
 WebKit/gtk/webkit/webkitwebview.h |    4 ++--
 2 files changed, 17 insertions(+), 2 deletions(-)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list