[Webkit-unassigned] [Bug 23194] [GTK] fix crashers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23194





------- Comment #10 from a.butenka at gmail.com  2009-01-12 14:21 PDT -------
adding null check for priv->corePage partly fixes a problem. After adding a
warning in if(!priv->corePage) im getting results like this:

$ ./GtkLauncher 'about:blank'
Segmentation fault
$  ./GtkLauncher 'http://google.com'
** (lt-GtkLauncher:13954): WARNING **: corePage is null
$

Backtrace: http://pastebin.com/m38551baf
Index: WebKit/gtk/webkit/webkitwebview.cpp
===================================================================
--- WebKit/gtk/webkit/webkitwebview.cpp (revision 39830)
+++ WebKit/gtk/webkit/webkitwebview.cpp (working copy)
@@ -602,14 +602,16 @@
 static void webkit_web_view_set_scroll_adjustments(WebKitWebView* webView,
GtkAdjustment* hadj, GtkAdjustment* vadj)
 {
     FrameView* view = core(webkit_web_view_get_main_frame(webView))->view();
+    WebKitWebViewPrivate* priv = webView->priv;

+    if(!priv->corePage)
+       return;
+
     if (hadj)
         g_object_ref(hadj);
     if (vadj)
         g_object_ref(vadj);

-    WebKitWebViewPrivate* priv = webView->priv;
-
     if (priv->horizontalAdjustment)
         g_object_unref(priv->horizontalAdjustment);
     if (priv->verticalAdjustment)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.