[Webkit-unassigned] [Bug 23116] [GTK] Fix crash due a callback called from GIO after the destruction of the ResourceHandle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23116





------- Comment #18 from otte at gnome.org  2009-01-12 01:54 PDT -------
On to the patch in detail:

> like in the previous bug, extra points if you could create a proper description
> here. Now I would have to do git commit --amend after taking your patch, or go
> though svn-apply..
> 
Yup, next patch will have the commit message as the ChangeLog. Bonus points if
I can attach patches with a git log, but without a ChangeLog entry.

> >  ResourceHandle::~ResourceHandle()
> >  {
> > +    cancel();
> >  }
> 
> This is creating a interesting question. If cancel was already called and we
> call cancel again nothing will happen. If it was not called before we will
> invoke call the ResourceHandleClient. This is something that this backend was
> not doing before and at least Qt is not doing that. I would prefer to not
> change the behavior without a good reason. 
> 
I actually looked into various backends and CURL calls cancel() unconditionally
in the destructor, so I guess it is fine.

> Okay, unrelated cleanup :)
> 
As said above, I considered it a rewrite, so I just made it a clean one :)

> > +        SoupMessage *msg = d->m_msg;
> 
> style
> 
Care toelaborate what I did wrong here?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.