[Webkit-unassigned] [Bug 23092] Conditionalize CFNetwork-specific logic in WebKit.dll

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23092


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26568|review?                     |review+
               Flag|                            |




------- Comment #9 from aroben at apple.com  2009-01-09 12:51 PDT -------
(From update of attachment 26568)
> -HRESULT STDMETHODCALLTYPE WebCookieManager::setCookieStorage( 
> -    /* [in] */ CFHTTPCookieStorageRef storage)
> -{
> -    setCurrentCookieStorage(storage);
> -    return S_OK;
> -}
> +}
> \ No newline at end of file

You should add a newline before committing.

> +UInt32 WebDownload::bundleMagicNumber()
> +{
> +   static UInt32 bundleMagicNumber = 0xDECAF4EA;
> +   return bundleMagicNumber;
> +}

We could probably just say "return 0xDECAF4EA", but it doesn't matter too much.

It's probably possible to trim down the #includes in the new *Curl.cpp files.

r=me

I don't think any of the changes I suggested will require a re-review.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.