[Webkit-unassigned] [Bug 23118] add Android platform-specific files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23118





------- Comment #8 from levin at chromium.org  2009-01-08 01:06 PDT -------
I glanced quickly out of curiosity.  Here's a few things I noticed along the
way.

* This one is frequently violated "In a header, code inside a namespace should
be indented."

* "Lower-case the first letter, including all letters in an acronym, in a
variable or function name." (violations: MIMEType, URLScheme)


In WebKit/android/FrameLoaderClientAndroid.cpp

* "occurances" is misspelled (a few times).

* The indents look wrong in serveral places.

* || and && happen at the end of lines instead of the beginning of the next
line in several places (e.g "if ((error.errorCode() == ErrorFile ||").

* Tests against 0 are to be done without ==/!=.  (e.g. "if
(m_frame->ownerElement() != 0)" should be "if (m_frame->ownerElement())" (and
imo, would be even clearer if it used ?: in this case).

* A few single line if's have {}


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.