[Webkit-unassigned] [Bug 23147] Introduce Skia to WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23147


oliver at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26507|review?(oliver at apple.com)   |review-
               Flag|                            |




------- Comment #18 from oliver at apple.com  2009-01-07 14:05 PDT -------
(From update of attachment 26507)
I'd like this patch split up somewhat more.  Ideally basic graphic context
stuff separate from the font stuff, for that reaosn r- (Font stuff is
sufficiently complex for me to want someone else to review it, i don't know
whether it should just be r+'d as a platform component for instance, or whether
there are real rules that are necessary)


But other issues
WebCoreRectToSkiaRect, etc -> these should not be in SkieUtils, they should be
in IntRectSkia, etc as with the other ports
i'm not sure i like WebCoreCompositeToSkiaComposite, but i feel
GraphicsContextSkia would be best
I don't have a clue what the hell SkColor SkPMColorToColor(SkPMColor pm) things
are :D

In general *Utils files are bad, functions should be placed in the files of
appropriate relevance, eg. IntRectSkia, and so on and so forth.

Didn't look at style at all.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.