[Webkit-unassigned] [Bug 23116] [GTK] fix random libsoup crashes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23116





------- Comment #6 from otte at gnome.org  2009-01-07 09:17 PDT -------
(In reply to comment #4)
> We always use four (4) spaces. Your patch still has a style issue...
>
Yeah, sorry, I missed 2 lines. On the plus side, I fixed indentation in
::startData, so my patch doesn't make the situation worse. Go me!

> This is backwards and will be ugly. You would need to know when the WebCore
> side is detached from the ResourceHandle... and then never ever call into the
> ResourceClient callbacks... It might be best to not use GIO for file/data at
> all...
> 
Not using GIO is not an option as far as I can see unless we want to manually
code up all formats - and that's not just file, but at least ftp, too.
And I'm sure I don't want to write another ftp backend, the one for GIO was
enough. So at least long term GIO is the way to go.

I'm fine with someone just ripping it out if he doesn't like my patch. But I'd
prefer to have a solution that does not make ~30 tests crash in every
LayoutTests run.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.