[Webkit-unassigned] [Bug 23147] Introduce Skia to WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23147


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26470|review?(sam at webkit.org)     |review-
               Flag|                            |




------- Comment #5 from eric at webkit.org  2009-01-06 14:27 PDT -------
(From update of attachment 26470)
AffineTransformSkia.cpp needs to be renamed to TransformationMatrixSkia.cpp
(and the class too) to match recent renames upstream.

I don't understand what GdkSkia.cpp is for.  Seems it should be in its own
separate patch.

WebKit style would use coundUsed instead of count_used

We don't use c-style casts in C++ code:
+    SkColor* colors = (SkColor*)storage.get();

GraphicsContextSkia needs its own patch.  It's too big to grok as part of this
one.

Image buffer probably too.

== stopped reading ==


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.