[Webkit-unassigned] [Bug 22614] Need to add Win32 implementation of ThreadSpecific.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22614





------- Comment #13 from jianli at chromium.org  2009-01-05 20:47 PDT -------
I fixed all the issues. Please review again. Thanks a lot.

(In reply to comment #11)
> > 1) You asked me to remove "copyright to apple". What should I put there?
> 
> My understanding is that you work for Google - so, it's actually a question for
> your manager. Normally, it's either a company or an individual that makes the
> contribution.
> 
> > 2) As to calling ThreadSpecificThreadExit, I do not think making the cleanup
> > call from WTF thread is enough. This approach does not take care of the TLS
> > cleanup in the main thread and other threads not created by WTF::createThread.
> 
> We don't care about cleanup on the main thread, similarly to how we
> intentionally avoid cleaning up most static objects for better performance.
> Also, ThreadSpecific objects are only used in WebCore, not JavaScriptCore, and
> all WebCore threads are created with WTF::createThread().
> 
> > I did not have a good solution here either. Which mailing list should I send to
> > for further discussion if needed?
> 
> There's always webkit-dev at lists.webkit.org :)
> 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.