[Webkit-unassigned] [Bug 23118] add Android platform-specific files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23118


oliver at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26430|review?                     |review-
               Flag|                            |




------- Comment #2 from oliver at apple.com  2009-01-05 08:55 PDT -------
(From update of attachment 26430)
First pass is just formatting issues, 
  * the opening '{' for a method should go the the line following the
prototype, 
  * license comments at the beginning of the files should have a single column
of '*' not '**' (I'd prefer these be lgpl v2 or bsd like the rest of webkit but
i am not sure if there's a rule about that)
  * Plenty of commented code like "//  virtual void
didChangeTypingStyle:(NSNotification *)notification;" exists which is less than
ideal, they should be converted to the appropriate platform specific model, and
have fixme's (or whatever) inserted.
  * Inside WebCore and WebKit rather than continually repeating
WTF::Vector/RefPtr etc you should put "using namespace WTF" at the top of the
implementation file and ddrop the naespace prefix
  * You should not be including a copy of the stl at all,  WTF provides
everything that should be necessary, and including stl for the hell of it is
folly


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.