[Webkit-unassigned] [Bug 23090] Redraw issue with width and opacity change

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23090


simon.fraser at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Comment #5 from simon.fraser at apple.com  2009-01-03 19:03 PDT -------
(In reply to comment #4)
> (From update of attachment 26393 [review])
> > +            } else if (m_style->hasTransform() != newStyle->hasTransform() ||
> > +                       m_style->hasOpacity() != newStyle->hasOpacity()) {
> > +                // If we don't have a layer yet, but we are going to get one because of a transform or opacity change, then
> >                  // we need to repaint the old position of the object
> 
> The comment is right, but the code is wrong. This will decide to repaint
> something that already has a layer if its opacity is going to change. Can we do
> a better check that gets this right? We want to repaint if "gets own layer" is
> going to change, so that's what we should be checking.

This is in a !hasLayer() clause, so it will actually do the right thing.
However, I will tidy up the logic.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.