[Webkit-unassigned] [Bug 23340] Add remaining bits of platform/graphics/chromium

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 15 11:13:48 PST 2009


------- Comment #3 from darin at apple.com  2009-01-15 11:13 PDT -------
(In reply to comment #2)
> Darin fisher learned I was wrong here:
>    else
>  71         // hack taken from the Windows port
>  72         m_xHeight = static_cast<float>(m_ascent) * 0.56;
> comments in else/if blocks supposedly cause them to be treated as multi-line by
> the style guides.  At least that was darin adlers opinion which darin fisher
> learned earlier this week.

Yes, right, we clarified this a while back. What is considered a one-line
control cause is the number of lines of code, including comments, not the
number of statements. The guideline is for the human being reading the code,
not for the compiler.

If someone's keeping a list of things we should clarify in the code style
guidelines document, I guess that should be one of them.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list