[Webkit-unassigned] [Bug 23642] [GTK] Drag and drop support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23642





------- Comment #4 from zandobersek at gmail.com  2009-02-28 12:49 PDT -------
(In reply to comment #3)
> (From update of attachment 27180 [review])
> > +#elif PLATFORM(GTK)
> > +typedef struct _GdkPixbuf GdkPixbuf;
> >  #endif
> 
> Shouldn't this be struct GdkPixbuf only? It seems to me like the typedef is an
> implementation detail that should not be propagated to client code.

This style of typedef statements is used all over the WebCore, that's why it is
used in the same way here. But I have no problem with changing it if needed.

> >  typedef enum
> >  {
> > -    WEBKIT_WEB_VIEW_TARGET_INFO_HTML = - 1,
> > -    WEBKIT_WEB_VIEW_TARGET_INFO_TEXT = - 2
> > +    WEBKIT_WEB_VIEW_TARGET_INFO_HTML = 1,
> > +    WEBKIT_WEB_VIEW_TARGET_INFO_TEXT,
> > +    WEBKIT_WEB_VIEW_TARGET_INFO_IMAGE,
> > +    WEBKIT_WEB_VIEW_TARGET_INFO_URI_LIST,
> > +    WEBKIT_WEB_VIEW_TARGET_INFO_NETSCAPE_URL
> >  } WebKitWebViewTargetInfo;
> 
> This is weird. This probably means breaking the ABI; is this something we
> should worry about? Why were these negative values used?

This patch was diffed out before the proper patch in #20412 [1] was reviewed
and committed into the trunk. A new patch takes that into account.

> I believe your patch does 2 very distinct things, so you should consider
> splitting it in two changes: one dealing with the clipboard, and another on top
> of that, dealing with the drag/drop thing.

The patch is now split into 3 - one dealing with GdkPixbuf conversion, one with
the drag clipboard and one with drag implementations.
The latter two will be attached here, while the first will be attached to
#15654 [2].

[1] https://bugs.webkit.org/show_bug.cgi?id=20412
[2] https://bugs.webkit.org/show_bug.cgi?id=15654


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.