[Webkit-unassigned] [Bug 24263] [GTK] ref ResourceHandle until we are finished with it

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24263





------- Comment #4 from christian at twotoasts.de  2009-02-28 12:31 PDT -------
2009-02-28  Xan Lopez  <xan at gnome.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=24263
        [GTK] ref ResourceHandle until we are finished with it

        Add a ref to the ResourceHandle in startHttp so we can keep it
        alive untill all callbacks have been executed, and unref it when
        soup tells us it's done with the SoupMessage (in
        finishedCallback). Fixes a number of crashes when calling
        didReceiveData whould crash because of the handle dying.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::finishedCallback):
        (WebCore::ResourceHandle::startHttp):

Adjusted the comment and used adoptRef as suggested and discussed on IRC.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.