[Webkit-unassigned] [Bug 24227] Implement checkForSolidColor in ImageQt.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24227





------- Comment #9 from jmalonzo at gmail.com  2009-02-28 05:16 PDT -------
(From update of attachment 28100)
Hi Adam

>      virtual void startAnimation(bool /*catchUpIfNecessary*/ = true) { }
> diff --git a/WebCore/platform/graphics/cairo/ImageCairo.cpp b/WebCore/platform/graphics/cairo/ImageCairo.cpp
> index 2850488..d4dd8ce 100644
> --- a/WebCore/platform/graphics/cairo/ImageCairo.cpp
> +++ b/WebCore/platform/graphics/cairo/ImageCairo.cpp
> @@ -60,6 +60,7 @@ BitmapImage::BitmapImage(cairo_surface_t* surface, ImageObserver* observer)
>      , m_repetitionCountStatus(Unknown)
>      , m_repetitionsComplete(0)
>      , m_isSolidColor(false)
> +    , m_checkedForSolidColor(false)
>      , m_animationFinished(true)
>      , m_allDataReceived(true)
>      , m_haveSize(true)

Should we also set m_checkedForSolidColor to true once
BitmapImage::checkForSolidColor has been called for the Cairo port?

Without this it will trigger the assert in line 220 of BitmapImage.h

Thanks


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.