[Webkit-unassigned] [Bug 23932] Current API does not allow us to open target="_blank" links in new tabs instead of windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23932





------- Comment #3 from gns at gnome.org  2009-02-27 19:14 PDT -------
(From update of attachment 28066)
Thanks for working on this; a much needed fix =).

> +static GObject *getNavigationAction(const NavigationAction& action)

The * should be close to the type here. Why not use WebKitNavigationAction
here, instead of GObject, by the way? It would look more correct to me, and
it's not like you're saving on casts by using GObject, right?

Otherwise looks good to me.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.