[Webkit-unassigned] [Bug 24227] Implement checkForSolidColor in ImageQt.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24227


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28097|review?                     |review+
               Flag|                            |




------- Comment #4 from eric at webkit.org  2009-02-27 12:16 PDT -------
(From update of attachment 28097)
if (!m_checkedForSolidColor) checkForSolidColor(); should be two lines. 
Otherwise looks good.

You shoudl add an ASSERT to mayFillWithSolidColor() and explain somewhere why
this works with images which are not loaded yet.  Perhaps in teh header next to
checkForSolidColor() // this shoudl check regardless of whether
m_checkedForSolidColor is set, as the frame may have changed.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.