[Webkit-unassigned] [Bug 23156] cant alignt text to the right using right shift and right ctrl

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 27 01:13:34 PST 2009


------- Comment #14 from hbono at chromium.org  2009-02-27 01:13 PDT -------
Thank you for your comments.

(In reply to comment #13)
> What will be the meaning of m_ctrlKey after this change? Will it be left Ctrl
> key, or any one? In most cases, we don't care which side the key was at.

To keep compatibility with the current WebKit, I thought 'm_ctrlKey' should
represent any control keys. Should we add comments to clarify this?

> We need to expose right/left information to DOM, see this FIXME in KeyboardEvent.cpp:
>     , m_keyLocation(key.isKeypad() ? DOM_KEY_LOCATION_NUMPAD : DOM_KEY_LOCATION_STANDARD) // FIXME: differentiate right/left, too

Thank you for noticing this.
I left this class unmodified in my previous change, because I'm wondering which
value we should set when we pressed a right modifier key and a left modifier
key, e.g. a right-shift key and a left-control key. As far as I read the DOM
Event spec, it does not write anything about such edge case. (This is also the
reason why my change just adds all right-modifier keys to the
PlatformKeyboardEvent class.)

(*1) http://www.w3.org/TR/DOM-Level-3-Events/events.html#Events-KeyboardEvent

Even though I prefer setting DOM_KEY_LOCATION_RIGHT when one of right modifier
keys are pressed, I'm not so confident of my opinion at all.
Would it be possible to give me your thoughts?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list