[Webkit-unassigned] [Bug 24221] [GTK] Do not emit load-finished when being disposed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24221


xan.lopez at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xan.lopez at gmail.com




------- Comment #3 from xan.lopez at gmail.com  2009-02-27 01:01 PDT -------
(In reply to comment #2)
> (From update of attachment 28067 [review])
> r=me
> 
> > +    /*
> > +     * We can get a stopLoad() from dispose when the object is being
> > +     * destroyed, don't emit the signal in that case.
> > +     */
> 
> We prefer C++-style comments in C++ files.

OK, was just being consistent with other multi-line comments in the file :)

> 
> Is this check needed before other g_signal_emit_by_name() calls?
> 

Does not seem so, this is the only signal emitted during dispose AFAICT. We
generally try to protect only the code paths needed on dispose, otherwise you'd
need to protect every single function and signal just in case.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.