[Webkit-unassigned] [Bug 24169] REGRESSION: gap.com (and affiliates) "QuickLinks" aren't linkfied

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 26 18:55:54 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=24169


cwzwarich at uwaterloo.ca changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|cwzwarich at uwaterloo.ca      |webkit-
                   |                            |unassigned at lists.webkit.org
          Component|Layout and Rendering        |Evangelism




------- Comment #6 from cwzwarich at uwaterloo.ca  2009-02-26 18:55 PDT -------
It turns out that this is due to a programming error in one of their JS
functions:

    checkMouseEvent: function(ele, target) {
        var isContain;
        if(target.contains) { isContain = !target.contains(ele); }
        if(target.compareDocumentPosition) { isContain =
target.compareDocumentPosition(ele); } 

        return target.contains ? isContain : isContain < 16;
    },

WebKit has supported IE's 'contains' DOM extension for a long time, but support
was added for 'compareDocumentPosition' in r35143. This function assumes that
no browser implements both. It is an easy fix, either

    checkMouseEvent: function(ele, target) {
        var isContain;
        if(target.contains) { isContain = !target.contains(ele); }
        else if(target.compareDocumentPosition) { isContain =
target.compareDocumentPosition(ele); } 

        return target.contains ? isContain : isContain < 16;
    },

or

    checkMouseEvent: function(ele, target) {
        var isContain;
        if(target.contains) { return !target.contains(ele); }
        else if(target.compareDocumentPosition) { return
target.compareDocumentPosition(ele) < 16; } 
    },

should work. This is really an evangelism bug, so I will unassign it from
myself.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list