[Webkit-unassigned] [Bug 23973] Chromium crashes at times when the view is being closed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 26 11:00:27 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=23973


darin at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27699|review?(sam at webkit.org)     |review-
               Flag|                            |




------- Comment #3 from darin at chromium.org  2009-02-26 11:00 PDT -------
(From update of attachment 27699)
>Index: WebCore/platform/ScrollView.cpp
...
> void ScrollView::scrollContents(const IntSize& scrollDelta)
> {
>+    if (!hostWindow())
>+      return;
>+

nit: the return statement should be indented by 4 spaces.  R- because
of this.

ScrollView appears to be designed with the assumption that the hostWindow
will never be null, but I can see from the callstack that assumption seems
to be invalid.  So, I think your solution is probably the best we can do.

Are any of the other ScrollView methods reachable from ~FrameView?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list