[Webkit-unassigned] [Bug 24193] [GTK] Checkbuttons not activated with space

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24193


ap at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28010|review?                     |review+
               Flag|                            |




------- Comment #2 from ap at webkit.org  2009-02-26 05:19 PDT -------
(From update of attachment 28010)
>         Do not swallow key events with GtkIMContext for non-editable
>         frames (FIXME: I don't think frame is the right name here).

That's non-editable content.

> +    if (!targetFrame || !targetFrame->editor()->canEdit())
> +        return;

Can targetFrame really be null here?

It's not obvious to me that no input method has useful functions for
non-editable content - some Mac IMs have such. So, it may be not quite correct
to do an early return here. But it's clear that this code is in need of large
refactoring anyway to support input events, and I think that this patch
improves the behavior more than it (potentially) regresses it.

>      // TODO: Dispatch IE-compatible text input events for IM events.

We use FIXME, not TODO. Even thought this is old code, it seems appropriate to
correct it now.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.