[Webkit-unassigned] [Bug 20358] [Gtk] font-variant: small-caps; is not working with libwebkit-1.0-1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 25 18:46:30 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=20358


zecke at selfish.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27607|review?                     |review+
               Flag|                            |




------- Comment #6 from zecke at selfish.org  2009-02-25 18:46 PDT -------
(From update of attachment 27607)

> -        desc.setSpecifiedSize(0.70f*fontDescription.computedSize());
> +        desc.setComputedSize(0.70f*fontDescription.computedSize());
           const FontPlatformData* pdata = new FontPlatformData(desc,
desc.family().family());

Cool, what is completely missing from the ChangeLog is the answer to the
question why this is the right fix. The FontPlatformData c'tor will use the
computedPixelSize of the FontDescription so we will have to set the
ComputedSize (like your patch does) and it also makes this statement look
symmetric... (just scaling..). Taking a look at Mac and Win there might be more
work ahead for custom fonts. I don't have a test case handy but we should be
able to locate one.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list