[Webkit-unassigned] [Bug 23866] Storage panel should be editable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23866


timothy at hatcher.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27855|review?(timothy at hatcher.name|review-
               Flag|)                           |




------- Comment #2 from timothy at hatcher.name  2009-02-25 17:57 PDT -------
(From update of attachment 27855)

> +    get statusBarItems()
> +    {
> +        return [this.deleteButton];
> +    },

The delete button should be on the view side of the status bar, like we do in
the ProfilesPanel/ProfilesView. A delete button here would imply deleting a
local/session storage object not a row. r- for this

> +            this.visibleView._dataGrid._deleteRow();

Functions that are "public" like _deleteRow() should not have an underscore.
Also deleteSelectedRow() would be best, since the row index isn't passed.

> +        var element = event.target.enclosingNodeOrSelfWithNodeName("td");

Why do you need to look for a element? Can't you get everything from
dataGridNodeFromEvent?

> +            }
> +            else {

This should be: } else { on the same line.


> +        if (node && domStorage) {
> +            domStorage.removeItem(node.data[0]);
> +        }

No need for braces here.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.