[Webkit-unassigned] [Bug 23957] SVG text gradients and patterns on chromium/skia don't work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23957


brettw at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-                     |senorblanco at chromium.org
                   |unassigned at lists.webkit.org |
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




------- Comment #11 from brettw at chromium.org  2009-02-25 16:06 PDT -------
+            // Don't give zero-width spaces a width.
+            if (!currentAdvance)
+                continue;

It's not clear what this has to do with this patch. I also don't entirely
understand the comment. Can you elaborate on why this needs special handling (I
assume we would otherwise remove extra letterspacing giving negative widths).

In static bool skiaDrawText(HFONT hfont... can you add a comment saying
gradient and pattern may be null?

+    if (gradient)
+        shader->resetLocalMatrix();

It seems like if somebody had a shader matrix on here, you will overwrite it.
When you create the shader, how about scaling the existing matrix rather than
setting the scale on the shader, and then restoring the original when you're
done.

This patch looks OK to me otherwise.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.