[Webkit-unassigned] [Bug 24143] Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24143


bdakin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27954|review?                     |review+
               Flag|                            |




------- Comment #5 from bdakin at apple.com  2009-02-25 13:35 PDT -------
(From update of attachment 27954)
Hey Chris! This patch looks good. My only comments really have to go with
naming conventions. I am not wild about the names get() and getIfExists(). How
about one of the following:

get() = getOrCreate()
getIfExists() = get()

or

get() = add()
getIfExists() = get()

The add() one is a little weird, I know, but that is a common naming convention
for this kind of thing is some other parts of WebCore…basically it means add
this to the cache or just return it if it already exists. That being said, I
like getOrCreate() as well, so you can choose whichever you prefer.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.