[Webkit-unassigned] [Bug 24152] Move the logic to do the unconfirmed message count and pending activity setting from WorkerMessagingProxy to Worker.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24152





------- Comment #3 from jianli at chromium.org  2009-02-25 08:07 PDT -------
Previously, worker object inquiries WorkerMessagingProxy about these info. So
it needs to check if WorkerMessagingProxy is in terminating state or not. Now
WorkerMessagingProxy passes these info directly to the worker object. So this
check is performed before calling into the worker object (see
WorkerMessagingProxy::reportPendingActivityInternal).

(In reply to comment #2)
> Just one question, previously the code looked like this:
>      return m_contextProxy->hasPendingActivity() ||
> ActiveDOMObject::hasPendingActivity();
> 
> where
> 
>      m_contextProxy->hasPendingActivity() was "(m_unconfirmedMessageCount ||
> m_workerThreadHadPendingActivity) && !m_askedToTerminate"
> 
> but now it is
> 
>      return m_unconfirmedMessageCount || m_workerContextHadPendingActivity ||
> ActiveDOMObject::hasPendingActivity();
> 
> Why is the loss of the m_askedToTerminate condition ok?
> 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.