[Webkit-unassigned] [Bug 24103] [GTK] Use correct return value for WebView button-release handler

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 24 11:47:13 PST 2009


------- Comment #5 from christian at imendio.com  2009-02-24 11:47 PDT -------
(In reply to comment #4)
> (In reply to comment #3)
> > > Slightly improve comment, don't confuse event with click.
> > 
> > While I would of course prefer to actually fix the event handlers in WebCore
> > that don't play together , I suppose this is a passable compromise.
> I'm not sure there's anything to fix. The event model and semantics of GTK+ and
> WebCore do not necesarily need to work OK together in all cases, and it's our
> responsibility to act as proxies between them. For this case in particular, ap
> says WebCore is working as it should be, for example.

Yes, I'm not suggesting to change WebCore. If anything, we could try to make
sure that a handled button-press is always followed by a handled
button-release, i.e. just keep track of what button-press did and do the same
in button-release.

> > We might want to document somewhere that WebKit won't ever catch button events
> > but still process them. Maybe in the introductory section of WebKitWebView?
> Yes, I guess this should be documented. Do you think this approach in general
> makes sense? We could do other things, like catch everything (return TRUE
> always for both events), catch nothing (return FALSE always for both events)...

I would think what I described above could be better. If that doesn't work for
whatever reason, always returning FALSE is probably the best we can do. 

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list