[Webkit-unassigned] [Bug 24055] Replace WorkerMessagingProxy with two separate proxy classes.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 20 16:01:37 PST 2009
https://bugs.webkit.org/show_bug.cgi?id=24055
------- Comment #4 from jianli at chromium.org 2009-02-20 16:01 PDT -------
(In reply to comment #2)
> (From update of attachment 27823 [review])
> > Index: WebCore/ChangeLog
> > + * GNUmakefile.am:
> > + * WebCore.vcproj/WebCore.vcproj:
> > + * WebCore.xcodeproj/project.pbxproj:
> missing some makefiles here.
>
These makefiles seem not to have all worker related files added so far.
>
>
> > Index: WebCore/dom/Worker.cpp
>
> > +void Worker::reportPendingActivity(bool confirmMessage, bool hasPendingActivity)
> WebKit eng is trying to move away from bool's to enums. I think that would be
> great here b/c I've found places calling this to be unreadable.
>
> Is the initial state of Worker::hasPendingActivity the same as it was before?
>
Yes.
>
>
> > Index: WebCore/dom/WorkerObjectProxy.h
>
> > +#include "ScriptExecutionContext.h"
> How is this used in this file?
>
Because we need it for enum like MessageDestination and MessageSource.
>
>
> > Index: WebCore/loader/WorkerThreadableLoader.cpp
>
> > - if (thisPtr->m_messagingProxy.askedToTerminate())
> > + if (thisPtr->isLoaderAlive())
> > return;
> This doesn't look like it serves the same purpose.
>
Fixed.
>
> > +void WorkerThreadableLoader::MainThreadBridge::postTaskToLoader(PassRefPtr<ScriptExecutionContext::Task>)
> > +{
> > + // FIXME: to be implemented.
> > + notImplemented();
> > +}
> I would hope that we could find a way to keep this working in WebKit at least
> even if it isn't cross platform (with respect to Chromium) for now.
>
Fixed.
>
> also:
> m_workerContext needs to be deref'ed on the worker context thread in
> MainThreadBridge::destroy.
>
>
Fixed.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list