[Webkit-unassigned] [Bug 24063] Allow port to require a user gesture to play/pause an <audio> or <video> element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24063


simon.fraser at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27836|review?                     |review+
               Flag|                            |




------- Comment #4 from simon.fraser at apple.com  2009-02-20 12:46 PDT -------
(From update of attachment 27836)
> Index: WebCore/html/HTMLMediaElement.cpp
> ===================================================================

>  void HTMLMediaElement::togglePlayState(ExceptionCode& ec)
>  {
>      if (canPlay())
> -        play(ec);
> +        playInternal(ec);
>      else 
> -        pause(ec);
> +        pauseInternal(ec);
>  }

Maybe add a comment to say why it's always OK to call the
internal methods.

> Index: WebCore/html/HTMLMediaElement.h
> ===================================================================

> +    void loadInternal(ExceptionCode& ec);
> +    void playInternal(ExceptionCode& ec);
> +    void pauseInternal(ExceptionCode& ec);

Add a comment to say why these are needed.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.