[Webkit-unassigned] [Bug 24042] MediaPlayer should cache plug-in proxy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24042


simon.fraser at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27817|review?                     |review+
               Flag|                            |




------- Comment #2 from simon.fraser at apple.com  2009-02-20 12:05 PDT -------
(From update of attachment 27817)

> Index: WebCore/platform/graphics/MediaPlayer.cpp
> ===================================================================

> +#if ENABLE(PLUGIN_PROXY_FOR_VIDEO)
> +    virtual void setPoster(const String&) { }

setPoster(const String& /*url*/) would be slightly clearer.


> Index: WebCore/platform/graphics/MediaPlayer.h
> ===================================================================
> --- WebCore/platform/graphics/MediaPlayer.h	(revision 41083)
> +++ WebCore/platform/graphics/MediaPlayer.h	(working copy)
> @@ -149,6 +149,9 @@ private:
>      bool m_visible;
>      float m_rate;
>      float m_volume;
> +#if ENABLE(PLUGIN_PROXY_FOR_VIDEO)
> +    WebMediaPlayerProxy* m_playerProxy;
> +#endif

Maybe add a comment to say that m_playerProxy is not owned and where
it comes from?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.