[Webkit-unassigned] [Bug 24063] Allow port to require a user gesture to play/pause an <audio> or <video> element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24063


simon.fraser at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27833|review?                     |review-
               Flag|                            |




------- Comment #2 from simon.fraser at apple.com  2009-02-20 12:01 PDT -------
(From update of attachment 27833)
> Index: WebCore/html/HTMLMediaElement.cpp
> ===================================================================

>  void HTMLMediaElement::loadTimerFired(Timer<HTMLMediaElement>*)
>  {
>      ExceptionCode ec;
> +
> +    ++m_internalCall;
>      load(ec);
> +    --m_internalCall;

I think it would be better for load() to wrap a loadInternal().
load() could do the permissions checking, and loadInternal() should
always load. Same with play() and pause().

> Index: WebCore/html/HTMLMediaElement.h
> ===================================================================

> +    enum BehaviorRestrictions 
>      { 
> -        NoLoadRestriction = 0,
> -        RequireUserGestureLoadRestriction = 1 << 0, 
> +        NoRestrictions = 0,
> +        RequireUserGestureLoadRestriction = 1 << 0,

RequireUserGestureForLoadRestriction
> +        RequireUserGestureRateChangeRestriction = 1 << 1,
RequireUserGestureForRateChangeRestriction

>      };
>  
>  
> @@ -237,7 +238,7 @@ protected:
>  
>      OwnPtr<MediaPlayer> m_player;
>  
> -    LoadRestrictions m_loadRestrictions;
> +    BehaviorRestrictions m_Restrictions;

m_Restrictions -> m_restrictions


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.