[Webkit-unassigned] [Bug 24054] Implement two separate proxy classes in order to split WorkerMessagingProxy.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24054





------- Comment #4 from dimich at chromium.org  2009-02-20 00:25 PDT -------
It seems that WorkerContextProxy::create(Worker*) is a bit unclear. It doesn't
really create a WorkerContextProxy since the latter is an abstract interface.

It could be better to have the following initialization sequence:
1. Worker constructor always first creates a local proxy to itself,
WorkerObjectCrossThreadProxy, passing itself as a parameter.
2. Then it can cast WorkerObjectCrossThreadProxy to base type WorkerObjectProxy
and pass that into a global function
createWorkerContextProxy(WorkerObjectProxy*), which in case of WebKit would
create a WorkerContextCrossThreadProxy, and in case of Chromium - an IPC pipe
and return something that implements WorkerContextProxy.

This also allows to get rid of
WorkerContextCrossThreadProxy::setWorkerObjectProxy() sinceit'll be passed to
constructor. 

Also, WorkerContextCrossThreadProxy does not seem to need
m_parentScriptExecutionContext, and so does not need this constructor
parameter. In Chromium case, it is also impossible to provide it in the worker
process. Was it intended for postTaskToLoader() implementation?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.