[Webkit-unassigned] [Bug 24011] KURL's setPort doesn't unset port if 0 is given

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24011


ap at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27765|review?                     |review+
               Flag|                            |




------- Comment #2 from ap at webkit.org  2009-02-19 02:21 PDT -------
(From update of attachment 27765)
r=me

> +        Make setPort remove port if 0 is given to it, as promissed by the

Typo: should be "promised".

>      // FIXME: Non-ASCII characters must be encoded and escaped to match parse() expectations,
>      // and to avoid changing more than just the port.

Oops, this FIXME is totally bogus - this method takes a number, so there is no
need to encode it! Please feel free to remove it if you wish.

> +    if (!i)

We'd normally put the normal code path first (if (i)).


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.