[Webkit-unassigned] [Bug 23989] The cursor behavior in GTK is wrong

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 18 01:25:31 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=23989


mrowe at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27743|review?                     |review+
               Flag|                            |




------- Comment #8 from mrowe at apple.com  2009-02-18 01:25 PDT -------
(From update of attachment 27743)
> +static GdkCursor* lastSetCursor = 0;

There's no need to explicitly initialise this to zero.

> @@ -85,11 +74,11 @@ void Widget::setCursor(const Cursor& cursor)
>      // gdk_window_set_cursor() in certain GDK backends seems to be an
>      // expensive operation, so avoid it if possible.
>  
> -    if (pcur == m_data->cursor)
> +    if (pcur == lastSetCursor)
>          return;
>  
>      gdk_window_set_cursor(gdkDrawable(platformWidget()) ? GDK_WINDOW(gdkDrawable(platformWidget())) : GTK_WIDGET(root()->hostWindow()->platformWindow())->window, pcur);
> -    m_data->cursor = pcur;
> +    lastSetCursor = pcur;
>  }

Ugh, does this code really use pcur as a variable name? :-(

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list