[Webkit-unassigned] [Bug 23986] run-sunspider --64-bit should work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23986





------- Comment #3 from ddkilzer at webkit.org  2009-02-17 07:24 PDT -------
(In reply to comment #2)
> Created an attachment (id=27725)
 --> (https://bugs.webkit.org/attachment.cgi?id=27725&action=view) [review]
> Work in progress patch
> 
> This patch seems to work but may need a bit of cleanup.  I'm a little bit
> unhappy about --64-bit meaning "32- and 64-bit" rather than selecting only the
> 64-bit variant like it implies, but that's how build-webkit already works.  We
> should probably rethink that at some point.

Parsing of the --64-bit flag should be done in webkitdirs.pm so that these
build flags may be shared by other build scripts automatically.

Also, some script variables use "SixtyFour" while others use "64".  I think I
prefer "64" since it stands out more.  (My brain doesn't like to parse
"SixtyFour", and even after it does parse it, it takes even longer to associate
it with "64-bit". :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.