[Webkit-unassigned] [Bug 15799] textPath element does not re-render when referenced path changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=15799





------- Comment #7 from rwlbuis at gmail.com  2009-02-17 01:21 PDT -------
Hi Niko,

(In reply to comment #5)
> (In reply to comment #4)
> > Created an attachment (id=27683)
 --> (https://bugs.webkit.org/attachment.cgi?id=27683&action=view) [review] [review]
> > First attempt
> > 
> > This covers not just the bug itself, but also changing attributes on the
> > textPath.
> > Cheers,
> > 
> Hi Rob,
> 
> the patch looks nice! Though I think the testcase should be rewritten, because
> it's not very obvious what happens first, what next etc..

Ok. The thing wss that the reduction was not enough, i.e. at one point I fixed
it but the original bug url still failed.

> I'd love to see more testcases:
> - one for a textPath attribute change (ie. startOffset)
> - one for a textPath child node change (modifying text child of <textPath>).
> - one which covers updating multiple clients (two references of the textPath)

Sounds reasonable. I'll have to check whether the second case is not actually
covered somewhere already, since the childrenChanged code is already there.

> Your testcase doesn't look very obvious (what happens first, it's not clear
> from a first sight, what is executed at which time, etc..) Also we shouldn't
> add new 'custom' testcases, but you should use the make-js-test-wrappers
> framework for this.

Ok, I am not familiar with make-js-test-wrappers, will have a look.

> Again the patch is great, just lacking some extensive tests.

Thanks! I'll try to improve the testcases as you pointed out an post a new
patch this week.
Cheers,

Rob.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.