[Webkit-unassigned] [Bug 16947] [GTK] Missing HTTP Auth challenge

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16947





------- Comment #32 from xan.lopez at gmail.com  2009-02-16 22:32 PDT -------
(In reply to comment #31)
> (In reply to comment #30)
> > I wonder if we should just go the extra mile and provide a way for the feature
> > to ask for the current toplevel each time 'authenticate' is fired. That way we
> > can keep it pure C and completely independent from WebKit.
> 
> I don't know how that would be done, but I would rather keep this simple. The
> current code plus that change can already be easily be copied to be used
> elsewhere with minimal change. And we don't really need to make simple things
> like this too generic, IMO.
> 

We just need a signal to connect from ResourceHandleSoup.cpp so we can pass the
current toplevel each time it's needed. I don't think it's much more complex
and it keeps the code modular. I wouldn't care too much in principle, but once
we have gone this far I think it's silly to break the copy&paste-ability at the
lat minute.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.