[Webkit-unassigned] [Bug 16947] [GTK] Missing HTTP Auth challenge

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 16 13:24:05 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=16947





------- Comment #28 from xan.lopez at gmail.com  2009-02-16 13:24 PDT -------
(In reply to comment #25)
> I'm playing with the patch here, and I like it. Some nitpicks:
> 
> >  8 files changed, 391 insertions(+), 2 deletions(-)
> >  create mode 100644 WebCore/platform/network/soup/webkit-soup-auth-dialog.c
> >  create mode 100644 WebCore/platform/network/soup/webkit-soup-auth-dialog.h
> 
> I believe you will want to rename these so that they match WebCore's naming
> convention.

Well, I've done this on purpose, because they are pure C files (and hence .c
and not .cpp), but I don't really care either way.

> 
> > +    gtk_window_set_default_size(GTK_WINDOW(dialog), 100, 50);
> > +    gtk_dialog_set_default_response(GTK_DIALOG(dialog), GTK_RESPONSE_ACCEPT);
> > +                                         
> 
> This last line, and some more in this file have unwanted trailing whitespaces.
> Since I know you're an Emacs user and enjoys learning new tricks I'm gonna say
> set show-trailing-whitespace to t and/or M-x delete-trailing-whitespace =)
> 

Ah, didn't know about the former, good one. Should also configure git to refuse
to commit with trailing white-space, that way you can't miss it :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list