[Webkit-unassigned] [Bug 16947] [GTK] Missing HTTP Auth challenge

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16947





------- Comment #25 from gns at gnome.org  2009-02-16 09:06 PDT -------
I'm playing with the patch here, and I like it. Some nitpicks:

>  8 files changed, 391 insertions(+), 2 deletions(-)
>  create mode 100644 WebCore/platform/network/soup/webkit-soup-auth-dialog.c
>  create mode 100644 WebCore/platform/network/soup/webkit-soup-auth-dialog.h

I believe you will want to rename these so that they match WebCore's naming
convention.

> +    gtk_window_set_default_size(GTK_WINDOW(dialog), 100, 50);
> +    gtk_dialog_set_default_response(GTK_DIALOG(dialog), GTK_RESPONSE_ACCEPT);
> +                                         

This last line, and some more in this file have unwanted trailing whitespaces.
Since I know you're an Emacs user and enjoys learning new tricks I'm gonna say
set show-trailing-whitespace to t and/or M-x delete-trailing-whitespace =)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.