[Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16401





------- Comment #176 from adam at yorba.org  2009-02-15 11:25 PDT -------
(In reply to comment #167)

I'm currently working on a new patch, and hope to post it here within the next
few days.  Christian, fortunately most of the points you raised have been
straightforward to deal with.  One question about this:

> > gdom_html_table_row_element_set_ch_off (GdomHTMLTableRowElement *thiz, gchar * value)
> 
> This fails if 'value' is NULL. I would think it would be easy on the API side
> if we allowed NULL and the _get_ counterpart also returns NULL if it's empty.
> Otherwise you have to do if(value && *value) in all code using that API, if you
> want to know if the value is actually empty.

The easiest way to fix this is to simply stop checking all string arguments for
NULL; instead, we can pass them to WebKit and let it complain if it's not happy
with a NULL argument.  Can you confirm that this seems like a reasonable idea?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.