[Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16401





------- Comment #175 from adam at yorba.org  2009-02-15 11:20 PDT -------
(In reply to comment #165)

> We might also add a "g_return_val_if_fail (!error || !*error, 0);" here.
> 
> > if(ec)
> 
> What happens if "error" is not set? We probably need "if(ec && error)" here?

Actually the existing code is intended to allow the caller to pass NULL for
error to ignore any error condition, so we don't want to g_return_val_if_fail
(!error).  In the generated code, the call to g_set_error_literal() is benign
if error == NULL, in which case that function does nothing by design (as
described in its documentation).


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.