[Webkit-unassigned] [Bug 16401] [GTK] GObject/C DOM binding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16401





------- Comment #165 from christian at imendio.com  2009-02-13 06:00 PDT -------
(In reply to comment #155)
> Created an attachment (id=27645)
 --> (https://bugs.webkit.org/attachment.cgi?id=27645&action=view) [review]
> GdomHTMLTableRowElement.cpp

> GdomHTMLTableRowElement *thiz

This should say "GdomHTMLTableRowElement *element", that's the usual convention
in Gtk.

We might also add a "g_return_val_if_fail (!error || !*error, 0);" here.

> if(ec)

What happens if "error" is not set? We probably need "if(ec && error)" here?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.