[Webkit-unassigned] [Bug 19243] Make SVG Masking platform aware

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19243





------- Comment #9 from eric at webkit.org  2009-02-12 13:11 PDT -------
(From update of attachment 27614)
I think this ASSERT will fail with large masks.  You should write a test case
with a super-large mask (or maybe we already have one?)

+void SVGResourceMasker::applyMask(GraphicsContext* context, const FloatRect&
boundingBox)
+{
+    if (!m_mask)
+        m_mask.set(m_ownerElement->drawMaskerContent(boundingBox,
m_maskRect).release());
+
+    ASSERT(m_mask);

All of these large mallocs could fail, we need to handle that.

basei would make more sense to me as pixelByteOffset or something. "i" could be
renamed "pixelOffset"  I'm not sure those names are super-clear, but they're
more clear than "i" and "basei" IMO.

I don't think you need a local for "alpha", (double)a should be sufficient.

Your' mixing float and double math here.  I would remove all of the f's from
these.  And 255 should be 255.0

Otherwise this looks fine.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.