[Webkit-unassigned] [Bug 23452] Add XHTMLMP support to Webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23452


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27560|review?                     |review-
               Flag|                            |




------- Comment #14 from darin at apple.com  2009-02-11 06:33 PDT -------
(From update of attachment 27560)
> +class HTMLNoScriptElement : public HTMLElement {
> +public:
> +    HTMLNoScriptElement(const QualifiedName&, Document*);
> +    ~HTMLNoScriptElement();
> +
> +    virtual bool checkDTD(const Node*);
> +    virtual void attach();
> +    virtual void recalcStyle(StyleChange);
> +    bool childShouldCreateRenderer(Node*) const;
> +};

~HTMLNoScriptElement and childShouldCreateRenderer should both be marked
virtual. All these functions should be private. I said most of this last time.
Please either do it or explain why you're not doing it, next time.

> +void HTMLNoScriptElement::attach()

What happened to my comment about sharing more code here? I don't understand
why you need these large functions for HTMLNoScriptElement::attach and
recalcStyle, since the behavior is the same as generic HTML elements, such as
<span>, when we're in the appropriate script mode. There should be more shared
code and less pasted here.

> +    while(parent = parent->parentNode()) {
> +        if(parentRenderer = parent->renderer())
> +            break;
> +    }

Formatting mistakes here. Need space after while and if.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.