[Webkit-unassigned] [Bug 23859] Change worker code to use different proxy class pointers.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23859





------- Comment #8 from levin at chromium.org  2009-02-10 12:26 PDT -------
*WebCore/dom/Worker.cpp
> Worker::hasPendingActivity() 

1. Can this method be called when m_contextProxy is 0 (after the Worker
constructor)?
Have all usages of m_contextProxy been checked to make sure that they won't be
used when it is 0.


*WebCore/dom/WorkerMessagingProxy.cpp
> m_unconfirmedMessageCount--; // workerThreadCreated checks if this count is 0.
Now, I understand why you moved it, but I still don't understand if this change
in what WorkerMessagingProxy::hasPendingActivity() returns is ok.  

It looks like there is a variable "m_workerThreadHadPendingActivity" to
indicate that the worker has pending activity.  Perhaps it should be used
instead of the message count in this case.


*WebCore/dom/WorkerContext.h
1. Extra blank lines added to the end.

*WebCore/dom/WorkerContextProxy.h
>   static WorkerContextProxy* create(const String& scriptURL, Worker* worker);
1. remove "worker". It doesn't add any info.


*WebCore/dom/WorkerThread.h
1. Extra blank lines added to the end.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.