[Webkit-unassigned] [Bug 23429] Frame Refactor: Move focusWindow/unfocusWindow/shouldClose/scheduleClose to Chrome
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 9 15:41:23 PST 2009
https://bugs.webkit.org/show_bug.cgi?id=23429
aroben at apple.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #27497|review- |review+
Flag| |
------- Comment #7 from aroben at apple.com 2009-02-09 15:41 PDT -------
(From update of attachment 27497)
> + Like the many other Chrome methods take a Frame* pointer. Update the
> + FrameLoader and the DOMWindow call site. In the FrameLoader it is assumed
> + that the page is around...
This last sentence doesn't seem necessary anymore -- there's no code in
FrameLoader in this patch that assumes there's a Page.
You need to patch WebView::shouldClose in WebKit/win/WebView.cpp as well.
r=me
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list